Skip to content

TWE-47 Move canoncial tags to base template - #440

Merged
JakubMastalerz merged 2 commits into
mainfrom
BAU/TWE-47-canonical-tags
Jul 21, 2026
Merged

TWE-47 Move canoncial tags to base template#440
JakubMastalerz merged 2 commits into
mainfrom
BAU/TWE-47-canonical-tags

Conversation

@JakubMastalerz

@JakubMastalerz JakubMastalerz commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

TWE-47

Description of Changes Made

When applied, this PR will apply canonical tags to all pages through the base template instead of applying them to listing templates. Additionally, paginated pages' canonical tags behaviour changes to include the page number.

How to Test

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@JakubMastalerz JakubMastalerz self-assigned this Jun 25, 2026
@damwaingames
damwaingames self-requested a review June 25, 2026 14:22
Comment thread tbx/project_styleguide/templates/patterns/base_page.html Outdated
Comment thread tbx/project_styleguide/templates/patterns/base_page.html Outdated
@damwaingames
damwaingames self-requested a review June 25, 2026 15:33
@helenb

helenb commented Jul 3, 2026

Copy link
Copy Markdown
Member

@nicklee @tm-kn I think we might need to check this in relation to the incoming listing page changes, which update the cannonical urls for the filtered listings.

@JakubMastalerz

Copy link
Copy Markdown
Collaborator Author

@helenb Just fyi, this work is considered "blocked" for now, as discussed here: https://torchbox.slack.com/archives/C06AQA4D0RX/p1783001032710819

@JakubMastalerz
JakubMastalerz force-pushed the BAU/TWE-47-canonical-tags branch from 51d4083 to 3e5ff4a Compare July 16, 2026 14:13
@helenb
helenb temporarily deployed to torchbox-com-staging July 16, 2026 14:51 Inactive
@JakubMastalerz
JakubMastalerz merged commit 905090b into main Jul 21, 2026
8 checks passed
@JakubMastalerz
JakubMastalerz deleted the BAU/TWE-47-canonical-tags branch July 21, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants