web: Cap growing static files at Content-Length#3693
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
StaticFileHandler calculated Content-Length before streaming, but its content iterator read to EOF. If the file grew between those operations, the response exceeded its advertised length and the connection closed. Limit emitted chunks to the calculated response length while preserving the get_content override contract. Add a live-server regression test. Fixes tornadoweb#2769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2769.
StaticFileHandlercalculatesContent-Lengthbefore streaming but reads the file to EOF, so a file that grows during the request overruns the advertised length and closes the connection. Limit emitted chunks to the calculated response length while preserving the existingget_content(..., end=None)override contract.The live-server regression grows the file between sizing and streaming; it fails with
HTTPOutputErrorbefore the fix and passes after it.StaticFileTestpasses all 34 tests, and Black, flake8, and mypy (Linux/Windows) pass on both changed files. The full local Python 3.14 suite has one unrelated baseline failure intest_no_open_redirect.