Restore ISO-8859-1 encoding for accented country names - #10
Merged
Conversation
The official TPC-DS 4.0.0 answer sets emit these names in ISO-8859-1 and the library reads distribution files as ISO-8859-1, so a UTF-8 countries.dst produced corrupted values (both in generated files and via the Trino connector).
raunaqmorarka
force-pushed
the
fix-country-encoding-iso-8859-1
branch
from
June 23, 2026 06:44
3b0cfee to
82ccf68
Compare
wendigo
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official TPC-DS 4.0.0 answer sets emit accented country names in ISO-8859-1, and the library reads distribution files as ISO-8859-1 (
DistributionUtils) and writes generated output as ISO-8859-1 (TableGenerator). Commit a1e81d5 re-encodedcountries.dstto UTF-8, which the ISO-8859-1 reader then corrupted:CÔTE D'IVOIREbecameCÃ"TE D'IVOIREboth in generated files and through the Trino connector path.This reverts a1e81d5, restoring
countries.dstto ISO-8859-1 (CÔTE D'IVOIRE=0xD4,RÉUNION=0xC9) and the correspondingTestCustomerGeneratorMD5s. The bytes now match the officialanswer_sets/30.ans, which is the fidelity target.