Skip to content

fix(runtime): normalize Windows workspace paths - #3286

Open
SulimanAbdulrazzaq wants to merge 1 commit into
ultraworkers:mainfrom
SulimanAbdulrazzaq:fix/3278-windows-workspace-path
Open

fix(runtime): normalize Windows workspace paths#3286
SulimanAbdulrazzaq wants to merge 1 commit into
ultraworkers:mainfrom
SulimanAbdulrazzaq:fix/3278-windows-workspace-path

Conversation

@SulimanAbdulrazzaq

Copy link
Copy Markdown

Summary

  • Normalize Windows extended-length (\\?\) and regular path representations before enforcing workspace boundaries.
  • Cover DOS and UNC prefix variants with regression tests.

Fixes #3278

Anti-slop triage

Verification

  • cargo fmt --manifest-path rust/Cargo.toml --all -- --check
  • git diff --check
  • cargo +stable-x86_64-pc-windows-gnu check --manifest-path rust/Cargo.toml --target x86_64-pc-windows-gnu -p runtime
  • cargo +stable-x86_64-pc-windows-gnu clippy --manifest-path rust/Cargo.toml --target x86_64-pc-windows-gnu -p runtime --lib (completed with existing warnings outside this change)
  • Runtime unit tests: the repository's Windows-target test build currently fails in pre-existing Unix-only std::os::unix::fs::PermissionsExt tests; the default MSVC toolchain also lacks link.exe in this environment.
  • No secrets, tokens, private logs, or unrelated generated files are included.

Resolution gate

Keep extended-length and regular Windows paths comparable when enforcing workspace boundaries, including first-run roots that cannot yet be canonicalized. Add regression coverage for DOS and UNC path forms.

Signed-off-by: Suliman Abdulrazzaq <suliman9000a@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grep_search: spurious "escapes workspace boundary" on first run in a directory with no .claw/ (Windows)

1 participant