fix(chart): default values now use an existing secret to fix deployment - #75
Merged
gCyrille merged 1 commit intoJul 20, 2026
Merged
Conversation
JeremyLARDENOIS
requested changes
Jul 17, 2026
…nt as described in documentation
gCyrille
force-pushed
the
74-documentation-inconsistency-about-configuration-secret
branch
from
July 17, 2026 14:47
590c4f9 to
7f36659
Compare
JeremyLARDENOIS
approved these changes
Jul 17, 2026
gCyrille
deleted the
74-documentation-inconsistency-about-configuration-secret
branch
July 20, 2026 07:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? (description)
This PR set a default value for
existingConfigSecretto match the installation documentation (section Method 1: kubectl)Fixes #74
Why? (reasoning)
After the previous changes to Allow usage of env var instead of secret config file for xo config, the volume mount for the secret was removed from the deployments.
Acceptance
Please use the following checklist:
make lint)make unit)