Skip to content

fix(chart): default values now use an existing secret to fix deployment - #75

Merged
gCyrille merged 1 commit into
mainfrom
74-documentation-inconsistency-about-configuration-secret
Jul 20, 2026
Merged

fix(chart): default values now use an existing secret to fix deployment#75
gCyrille merged 1 commit into
mainfrom
74-documentation-inconsistency-about-configuration-secret

Conversation

@gCyrille

Copy link
Copy Markdown
Collaborator

What? (description)

This PR set a default value for existingConfigSecret to match the installation documentation (section Method 1: kubectl)

Fixes #74

Why? (reasoning)

After the previous changes to Allow usage of env var instead of secret config file for xo config, the volume mount for the secret was removed from the deployments.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you linted your code (make lint)
  • you linted your code (make unit)

See make help for a description of the available targets.

@gCyrille
gCyrille requested a review from JeremyLARDENOIS July 17, 2026 13:42
@gCyrille gCyrille self-assigned this Jul 17, 2026
@gCyrille gCyrille added the bug Something isn't working label Jul 17, 2026

@JeremyLARDENOIS JeremyLARDENOIS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, i didn't look about existingConfigSecret 😅

Comment thread charts/xenorchestra-cloud-controller-manager/values.yaml
@gCyrille
gCyrille force-pushed the 74-documentation-inconsistency-about-configuration-secret branch from 590c4f9 to 7f36659 Compare July 17, 2026 14:47
@gCyrille
gCyrille requested a review from JeremyLARDENOIS July 17, 2026 15:36
@gCyrille
gCyrille merged commit 42b19e5 into main Jul 20, 2026
2 checks passed
@gCyrille
gCyrille deleted the 74-documentation-inconsistency-about-configuration-secret branch July 20, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation inconsistency about configuration secret

2 participants