Skip to content

Added note for users to test fstab before rebooting#904

Open
SyntaxError2505 wants to merge 1 commit into
void-linux:masterfrom
SyntaxError2505:master
Open

Added note for users to test fstab before rebooting#904
SyntaxError2505 wants to merge 1 commit into
void-linux:masterfrom
SyntaxError2505:master

Conversation

@SyntaxError2505

Copy link
Copy Markdown

Added instructions for running 'mount -a' to check fstab issues. This can help users at not having to trouble shoot in a scary recovery mode.

Added instructions for running 'mount -a' to check fstab issues and enabled TRIM for LVM by modifying lvm.conf.
@classabbyamp

Copy link
Copy Markdown
Member

this will cause partitions to get mounted over the existing mount in the live environment.

@SyntaxError2505

Copy link
Copy Markdown
Author

Do you mean that this will break if ran in the live environment? I have installed void linux and use this to test fstab. mount -a will only mount partitions mentioned in fstab and it wouldn't make sense that the live environment usb is inside. Please explain further

@classabbyamp

Copy link
Copy Markdown
Member

well, I guess it's not as bad as I was thinking, but per mount(8):

           Note that it is a bad practice to use mount -a for fstab checking.
           The recommended solution is findmnt --verify.

It'd be good to add a similar note in other places where the fstab is created/edited.


btw, you can ignore the link check failure, that's unrelated to your change

@SyntaxError2505

Copy link
Copy Markdown
Author

Yep. So you add the notes? I've only noticed fstab being mentioned here. Mount -a is how Google did it when I finally ran into a problem with fstab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants