[FIX] Parameterization - #34
Open
ryanhammonds wants to merge 5 commits into
Open
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
==========================================
- Coverage 66.86% 65.72% -1.15%
==========================================
Files 8 8
Lines 824 849 +25
==========================================
+ Hits 551 558 +7
- Misses 273 291 +18
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows y_array to be initialized in a parameterized WorkFlow, before it expected a bids repo or building y_array from .simulate calls.
The API needs to be simplified / re-written at some point. At the least, it could use stronger tests for a limited number of supported use case + profiling to fix bottlenecks and drop lines that are unused + better error/warning handling.