feat: add Waline comment system support - #169
Conversation
|
OK, but it may not start until this weekend. I am preparing for my exam recently. |
|
Don’t worry, good luck with your exam!
在 2022年3月8日，22:32，Mashiro ***@***.***> 写道：
OK, but it may not start until this weekend. I am preparing for my exam recently.
—
Reply to this email directly, view it on GitHub<#169 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJEXGNAQBM5GDEBBXUIAVH3U7ALT3ANCNFSM5QEBGMDA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
wangchucheng
left a comment
wangchucheng
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Just some points above.
| new Waline({ | ||
| el: "#waline-comments", | ||
| requiredMeta: [ 'nick','mail' ], | ||
| dark: "html[class=\"fontawesome-i2svg-active fontawesome-i2svg-complete dark\"]", |
There was a problem hiding this comment.
Do we need the fontawesome-i2svg-active fontawesome-i2svg-complete here? Eureka only uses dark to indicate that it is dark mode.
And maybe we need to make it configurable and add a new possible value (maybe eureka) to do this instead of doing it by default. You can refer to how utterances in eureka handles this.
There was a problem hiding this comment.
It's really not elegant enough here, I think it would be better to change it to dark: "html.dark".
There was a problem hiding this comment.
And make it configurable is a good idea, but I think move dark: "html.dark" to params.yaml maybe more concise. Just leave it blank when don't need it.
There was a problem hiding this comment.
And you also need to handle the possible duplication of this param since you manually added it and users may set it in config.
2 participants
Because of security, I want to add Waline comment system support, and it adapted for dark mode.