fix(app-headless-cms): wire dropConfirmation to FolderTree and block visual update until confirmed - #5560
Merged
Conversation
…visual update until confirmed - Pass dropConfirmation prop from ContentEntryListConfig to FolderTree in SidebarContent - Move presenter.handleDrop after onDrop callback in Tree's useTree so the visual tree update only applies after the consumer's callback resolves - Wrap confirmation dialog in a promise so onDrop blocks until user confirms or cancels - Pass onClose callback through useConfirmMoveFolderDialog to detect cancellation - Add test extension for Browser.Folder.DropConfirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropConfirmationconfig prop fromContentEntryListConfigthrough toFolderTreein the HeadlessCMS sidebar — it was resolved but never passedTreecomponent (admin-ui) to runonDropbefore the visual tree update, so consumers can block or cancel the reorderonDropblocks until the user confirms or cancels, preventing the premature visual moveextensions/folderDropConfirmation) demonstratingBrowser.Folder.DropConfirmationChanges
packages/app-headless-cms/.../SidebarContent.tsx— passdropConfirmationprop toFolderTreepackages/admin-ui/src/Tree/useTree.ts— movepresenter.handleDropafteronDrop; catch throws to skip the visual update on cancellationpackages/app-aco/.../List.tsx— wrap confirmation dialog in a blocking promisepackages/app-aco/.../useConfirmMoveFolderDialog.tsx— forwardonClosecallback to the dialog systemextensions/folderDropConfirmation/index.tsx+webiny.config.tsx— test extension registrationTest plan
Treeconsumer)