fix(app-file-manager): gate accessControl behind canUsePrivateFiles WCP check - #5568
Merged
Merged
Conversation
…CP check FileDetailsPresenter unconditionally sent accessControl in the UpdateFile mutation payload. When Private Files is not licensed, the API removes accessControl from FmFileUpdateInput, causing every file save to fail with a GraphQL validation error. Inject WcpService and gate accessControl in buildForm(), loadFile(), and saveFile() behind canUsePrivateFiles(). Add tests for the unlicensed path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileDetailsPresenter.saveFile()unconditionally sentaccessControlin theUpdateFilemutation payload. When Private Files is not licensed, the API removesaccessControlfromFmFileUpdateInput, causing every file edit (name, description, tags) to fail with:Field "accessControl" is not defined by type "FmFileUpdateInput".WcpServiceintoFileDetailsPresenterand gate allaccessControlusage inbuildForm(),loadFile(), andsaveFile()behindcanUsePrivateFiles()— matching the existing pattern inFileFieldsProviderWithWcp.Test plan
FileDetailsPresentertests pass (licensed path unchanged)accessControlis omitted from save payload, form data, and field disable calls🤖 Generated with Claude Code