Skip to content

Download all country maps & Use OSM instead of google maps for locations - #220

Open
ToppAce wants to merge 11 commits into
masterfrom
maps
Open

Download all country maps & Use OSM instead of google maps for locations#220
ToppAce wants to merge 11 commits into
masterfrom
maps

Conversation

@ToppAce

@ToppAce ToppAce commented Nov 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Beschreibung

closes #212:

  • create a script to download all maps from highcharts, so they don't have to be loaded on the run
  • download the maps
  • change the projects_map template

closes #216:

  • use easy_thumbnails to deal with partner logos

closes #197:

  • implement the widget of django-location-field to our existing field in the Location model. In this way no migration are necessary

Typ

Unzutreffendes bitte löschen

  • DSGVO
  • Neues Feature

@ToppAce
ToppAce requested a review from bhemmer November 19, 2020 09:41
bhemmer
bhemmer reviewed Nov 22, 2020
View reviewed changes

@bhemmer bhemmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes/questions/comments.
I leave this PR open for @spuetz to merge and deploy.

Comment thread wbcore/management/commands/download_country_maps.py Outdated
Comment thread wbcore/management/commands/download_country_maps.py Outdated
Comment thread wbcore/management/commands/download_country_maps.py
Comment thread weitblick/settings.py Outdated
@ToppAce ToppAce changed the title Download all country maps Download all country maps & Use OSM instead of google maps for locations Dec 2, 2020
bhemmer
bhemmer reviewed Jan 19, 2021
View reviewed changes
Comment thread wbcore/templates/wbcore/projects_map.html Outdated
@bhemmer

bhemmer commented Jul 1, 2021

Copy link
Copy Markdown
Member

@ToppAce did we refer to the by licence by highmaps somewhere?

@ToppAce

ToppAce commented Jul 2, 2021

Copy link
Copy Markdown
Contributor Author

@ToppAce did we refer to the by licence by highmaps somewhere?

I added the attribution on the maps:
grafik

As it is a "Creative Commons (CC) Attribution-Noncommercial license" I guess this should be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhemmer bhemmer bhemmer left review comments

Assignees

@spuetz spuetz

@bhemmer bhemmer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thumbs for partner logos: Make all the same size download highmaps for all countries google maps inset (location admin) needs billing

3 participants

@ToppAce @bhemmer @spuetz