fix(firmware): zero FR blank-state defaults, fix stale onset-delay docs - #50
Merged
Conversation
…cs (#49) fr/Config.h's DEFAULT_CUE_FREQUENCY/DURATION, DEFAULT_PUMP_DURATION, DEFAULT_LASER_FREQUENCY/DURATION, and DEFAULT_TIMEOUT_INTERVAL still held their old non-zero values from before the per-device onset-delay refactor, so a freshly-flashed board fired real cue/pump/laser output the moment a device was armed, before any experimenter configuration. Zero all six so the board ships inert until explicitly configured. Also rewrites firmware/README.md's FR section, which still described the old cue-offset-relative "trace interval" chaining model — no longer present in code — instead of the current per-device onset-delay model. Recompiled and committed the refreshed fr.hex; pr/vi/omission/pavlovian hex are unaffected (each paradigm has its own Config.h, intentionally left untouched here). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fr/Config.h's sixDEFAULT_*constants (cue frequency/duration, pump duration, laser frequency/duration, timeout) so a freshly-flashed FR board is inert until explicitly configured — arming a device no longer fires real output on a lever press.fr.hex(pr/vi/omission/pavlovian hex unaffected — each paradigm owns its ownConfig.h).firmware/README.md's FR section, which still described the old cue-offset-relative "trace interval" chaining model (no longer present in code) instead of the current per-device onset-delay model.Closes #49
Test plan
bash firmware/compile.sh— all 5 sketches compile; onlyfr.hexchanged (confirmed viagit status)pytest— 296 passedfr.hexto a Mega 2560, arm cue/pump without setting duration, confirm no tone/infusion on lever press