Improve Unicode regex full-fold parity - #911
Merged
Merged
Conversation
Derive complete multi-character folds from ICU4J, recognize escaped fold components and character classes, and preserve the distinct /a and /aa semantics during regex compilation. Generated with [Codex](https://developers.openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/aand/aacompiler flags and avoid rewriting across scoped(?aa:...)groups/aversus/aaFold results
re/reg_fold.tre/fold_grind_u.tre/fold_grind_d.tre/fold_grind_a.tre/fold_grind_aa.tThe grind files summarize successful internal subtests but emit individual failures, so a lower denominator means additional internal cases now pass silently.
op/ref.tremains unchanged at 421/481 and is outside this fold-focused change.Validation
make— passed, all unit shards (5m12s)prove src/test/resources/unit/regex_full_casefold.twith system Perl — 8/8 passedperl_test_runner.plcomparison — no timeouts; fold counts above