feat(motd): add uwelcome + update umotd

[theMimolet]

Good day 👋

PR pipeline

opened ──▶ review ──▶ approved ──▶ merged
                    [lgtm]      auto-merge
                                when CI green

Add do-not-merge at any time to block automation.
/approve or lgtm from a maintainer triggers merge queue.

What does this change?

It replaces the old unified umotd config file by the two new ones for umotd and uwelcome.

Why?

To update them and make them work together.
(also so you can use umotd in other programs as it only prints translated messages)

Checklist

• just check passes
• pre-commit run --all-files passes
• PR title follows Conventional Commits (fix:, feat:, chore:, etc.)

Summary by CodeRabbit

• New Features
  • Added support for additional desktop/profile tags, including Bluefin and GNOME.
  • Updated the welcome/MOTD experience to use uwelcome toggle, including updated greeting structure and MOTD command grouping.
• Bug Fixes
  • Refreshed welcome and MOTD behavior to improve consistency of the displayed greeting/prompt.
• Chores / Security
  • Updated the container build to compile and ship uwelcome alongside umotd, and refreshed bundled udev asset verification.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds system tags, updates uwelcome configuration, builds uwelcome alongside umotd, and switches profile and task integration to uwelcome.

Changes

System Welcome Integration

Layer / File(s)	Summary
Update welcome configuration system_files/shared/etc/ublue-os/tags.json, system_files/shared/etc/uwelcome/config.json	Adds bluefin and gnome tags, changes the toggle command to uwelcome toggle, relocates the greeting prefix, and replaces prior MOTD settings with motd.commands: ["umotd"].
Build and install welcome utilities Containerfile	Updates pinned umotd build inputs, adds a pinned uwelcome build stage, preserves image setup and udev verification, and copies both binaries into the output.
Update welcome entry points system_files/shared/etc/profile.d/uwelcome.sh, system_files/shared/usr/share/ublue-os/just/default.just	Switches the profile script to invoke uwelcome and removes the obsolete toggle-user-motd task.

Estimated code review effort: 2 (Simple) | ~12 minutes

Suggested reviewers: ahmedadan, inffy, ledif, renner0e, castrojo

Poem

A rabbit hops through tags of blue,
And welcomes fresh commands anew,
Two tools now build and land just right,
The MOTD starts its morning light. 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise, conventional, and accurately summarizes the main change.
Description check	✅ Passed	The description follows the template structure and clearly explains what changed and why.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[castrojo]

I don’t see a ship/install path for uwelcome in this repo. The new config switches the command to , but the image only appears to install/ship
�[38;5;104;1m󱍢 Welcome to�[m�[38;5;104;1m Bluefin�[m

[Ci] �[38;5;104;1m ghcr.io/projectbluefin/dakota:latest �[m

_ Command │ Description
──────────────────────────────────────┼─────────────────────────────────────
�[38;5;104;1m ujust --choose �[m │ List all available commands
�[38;5;104;1m umotd toggle �[m │ Toggle this banner on/off
�[38;5;104;1m ujust bluefin-cli �[m │ Enable terminal bling
�[38;5;104;1m brew help �[m │ Manage command line packages

�[38;5;104;1mSupport indie game preservation and OSS developers!�[m — �]8;id=1207160287;https://patreon.com/hitsave��[1mJoin Hit Save!'s�[m�]8;;�
�]8;id=1207160287;https://patreon.com/hitsave��[1mPatreon�[m�]8;;� �[38;5;104;4m�]8;id=1207160287;https://patreon.com/hitsave�https://patreon.com/hitsave�]8;;��[m

• �]8;id=3541281617;https://issues.projectbluefin.io/��[1mReport an issue�[m�]8;;� �[38;5;104;4m�]8;id=3541281617;https://issues.projectbluefin.io/�https://issues.projectbluefin.io/�]8;;��[m
• �]8;id=3766875054;https://ask.projectbluefin.io/��[1mAsk Bluefin�[m�]8;;� �[38;5;104;4m�]8;id=3766875054;https://ask.projectbluefin.io/�https://ask.projectbluefin.io/�]8;;��[m
• �]8;id=772340340;https://docs.projectbluefin.io/��[1mDocumentation�[m�]8;;� �[38;5;104;4m�]8;id=772340340;https://docs.projectbluefin.io/�https://docs.projectbluefin.io/�]8;;��[m today. Please either wire up uwelcome in the image or keep the config aligned with the actually shipped binary so the new path is functional.

[castrojo]

I don’t see a ship/install path for uwelcome in this repo. The new config switches the command to uwelcome toggle, but the image only appears to install/ship umotd today. Please either wire up uwelcome in the image or keep the config aligned with the actually shipped binary so the new path is functional.

[theMimolet]

tbf I was expecting you to do your magic
but I can try something out

[castrojo]

Vanguard Lab Strike Report

Field	Value
Workflow	common-815-feat-motd-add-uwelcome-update-l7vdh (link: http://192.168.1.102:32746/workflows/argo/common-815-feat-motd-add-uwelcome-update-l7vdh)
Phase	Failed
Duration	32m31s
Variants tested	bluefin:testing
Suites run	smoke

Results

Workflow phase: Failed
Failed nodes: 6 / 15 total (3 succeeded, 6 skipped)

assert-cd node:
  phase: Failed
  message: main: Error (exit code 1)

Relevant log/script excerpt:
  TAG="{{inputs.parameters.containerdisk-tag}}"
  CD_IMAGE="192.168.1.102:30500/bluefin-containerdisk:${TAG}"
  DIGEST=$(skopeo inspect --tls-verify=false --format '{{.Digest}}' \
    "docker://${CD_IMAGE}" 2>/dev/null || echo "")
  if [[ -n "${DIGEST}" ]]; then
    echo "containerdisk ${CD_IMAGE} ready: ${DIGEST}"
  else
    echo "ERROR: containerdisk ${CD_IMAGE} not found in Zot" >&2
    echo "The digest-watch CronWorkflow builds it when GHCR changes." >&2
    echo "Check: argo list -n argo --field-selector metadata.name=~build-cd-sync" >&2
    exit 1
  fi

Outcome:
  - The smoke test lane failed before provisioning a VM.
  - The common suite was skipped because the submitted workflow was configured with suites=smoke only.
  - No motd/uwelcome behavior was exercised.

Evidence collected via

• argo_get_workflow — workflow phase and node summary
• argo_logs_workflow — cleanup-orphan-vms log (test pod logs already recycled)
• kubernetes-mcp-resources_list — VMI state confirmed Ready (n/a: container-only pipeline)
• VM/orphan check — zero orphaned VMs after teardown

Merge-queue eligibility

• Argo workflow success: no
• No regressions vs base image: no / not determined
• PR mergeable (no conflicts, approvals present): no

Blockers / issues filed

• The existing Argo run for SHA 18ef56fc3d94 failed at the assert-cd step because bluefin-containerdisk:testing was not present in the cluster-local Zot registry.
• Only the smoke suite was submitted; the requested common suite was not run.
• PR has no human approvals (reviewDecision empty, label pr/needs-review) and mergeStateStatus is UNKNOWN.

[coderabbitai]

🧹 Nitpick comments (1)

Containerfile (1)

35-35: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use an absolute path for consistency.

The destination path out/shared/... is relative. While this works because the default working directory is /, it is inconsistent with other absolute paths used in this file (e.g., /out/shared/... in line 37). Consider adding a leading slash to ensure correctness if the working directory ever changes.

💡 Proposed refactor

-    install -Dpm0644 "$f" "out/shared/usr/lib/udev/rules.d/71-${f##*/}"; \
+    install -Dpm0644 "$f" "/out/shared/usr/lib/udev/rules.d/71-${f##*/}"; \

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Containerfile` at line 35, Update the install destination in the
Containerfile command to use the absolute /out/shared/usr/lib/udev/rules.d path,
matching the other absolute output paths while leaving the source handling
unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Containerfile`:
- Line 35: Update the install destination in the Containerfile command to use
the absolute /out/shared/usr/lib/udev/rules.d path, matching the other absolute
output paths while leaving the source handling unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad85393f-41c1-4596-b6f2-40603bf70edf

📥 Commits

Reviewing files that changed from the base of the PR and between 18ef56f and 3ea6b0a.

📒 Files selected for processing (1)

• Containerfile

[theMimolet]

It should be good now 👍

[hanthor]

Holding a neutral review — the build wiring looks coherent but I can't confirm the greeting path end-to-end from the diff alone, and there are a couple of concrete gaps worth resolving first:

1. uwelcome is installed but nothing in the image invokes it. The config moves from etc/umotd/config.json to etc/uwelcome/config.json and the new binary lands at /usr/bin/uwelcome, but on this branch both greeting entrypoints — fish_greeting.fish (function fish_greeting; umotd; end) and profile.d/umotd.sh — still call umotd, not uwelcome. If the new umotd is now "only prints translated messages" (per the PR description) and uwelcome is the front-end that reads etc/uwelcome/config.json, then the greeting needs to switch to uwelcome; otherwise the interactive welcome (commands/links) silently regresses. If instead umotd still delegates internally, please confirm it reads the new etc/uwelcome/ path.

2. default.just toggle mismatch. umotd toggle in default.just is unchanged, but the new config's toggle command is uwelcome toggle. These should agree.

3. Supply chain: uwelcome is cloned from the personal github.com/themimolet/uwelcome rather than an org-owned repo (unlike umotd from projectbluefin/motd). Intentional, or should it be migrated under the org before it ships in the image?

Minor: the Containerfile carries a lot of unrelated 2→4-space reindentation churn (the gdu checksum block, etc.). The values are unchanged — CodeRabbit's "refreshed SHA-256" note is a misread of the whitespace — but the noise makes the diff harder to audit; consider splitting it out. CI is green. Happy to approve once the greeting wiring (item 1) is confirmed.

[theMimolet]

For No. 1 I completely forgot.
For No. 2 I thought it was already the case.
For No. 3 I don't have permission to create repos, so I'm doing what I can 🥲

[theMimolet]

yeah my bad, i don't know why I didn't think about it
all good now 👍

[hanthor]

The uwelcome migration is a good direction, but there are two things to fix before this ships.

1. The fish migration will error on every shell start

system_files/shared/usr/share/fish/vendor_conf.d/fish_greeting.fish:

if test -e ~/.config/no-show-user-motd
    mv ~/.config/no-show-user-motd ~/.config/uwelcome/disabled
end

Two problems, and they compound:

• There's no 2>/dev/null here, unlike the profile.d version.
• ~/.config/uwelcome/ is not created anywhere in this PR. If it doesn't exist, mv fails.

So for any user who had opted out via no-show-user-motd, the mv fails, fish prints an mv error, and — because the source file is never removed — it fails again on every new fish shell, forever. The profile.d path has the same missing-directory bug; it just hides the error instead of showing it, which means the opt-out silently never migrates.

Both paths need the directory created first, e.g.:

if test -e ~/.config/no-show-user-motd
    mkdir -p ~/.config/uwelcome
    mv ~/.config/no-show-user-motd ~/.config/uwelcome/disabled 2>/dev/null
end

and the equivalent in uwelcome.sh. Worth confirming against uwelcome upstream that ~/.config/uwelcome/disabled is actually the path it checks, since the whole migration hinges on it.

2. Two tests were commented out rather than fixed

In tests/test_motd_integration.bats:

# @test "uwelcome.sh: does not contain no-show-user-motd check" {
# @test "fish_greeting: does not check no-show-user-motd (opt-out delegated to uwelcome)" {

These were live assertions in test_umotd_integration.bats and are now dead. I understand why — the migration shim does reference no-show-user-motd, so they'd fail as written. But leaving them commented out means the file's own header comment ("Neither profile.d nor fish_greeting should check for that file or gate the uwelcome invocation") no longer describes the code, and nothing enforces the shim's shape.

Please either delete them and update the header comment to describe the migration as it actually is, or rewrite them to assert what you now want — e.g. that the reference appears only inside the migration block and that uwelcome is invoked unconditionally afterward. A commented-out test is the one outcome that leaves no record of which it was.

Minor

• tests/test_umotd_integration.bats also dropped the three toggle-user-motd recipe tests along with the recipe itself. That's consistent (the recipe moved to uwelcome toggle in the config JSON), but users with muscle memory for ujust toggle-user-motd now get "recipe not found" with no pointer. Consider keeping a stub recipe that execs uwelcome toggle.
• The Containerfile reindentation is a large share of the diff and makes the substantive uwelcome-build-stage addition harder to spot. Not worth re-rolling for, just noting for next time.

---

Generated by Claude Code

[hanthor]

Following up my earlier review with actual patches — the two mkdir -p suggestions are click-to-apply, and the third replaces one of the commented-out tests with one that pins the bug.

I verified the failure against the branch rather than reading it off the diff: ~/.config/uwelcome/ is not created by anything in this PR, so on a machine where uwelcome has never written its config dir, the mv fails in both shells. The fish path shows the error every shell start; the bash path swallows it and silently leaves the user opted in despite their earlier opt-out.

---

Generated by Claude Code

[theMimolet]

Thanks for the fixes and tests, I didn't think about that
I restored the spaces by hand (i'm rather curious on which formatter you use)

As for the supply chain issue you mentioned a while back now, I've invited Ahmed and Jorge on the repos and so they'll be able to transfer them whenever.

[ahmedadan]

Thanks for the fixes and tests, I didn't think about that I restored the spaces by hand (i'm rather curious on which formatter you use)

As for the supply chain issue you mentioned a while back now, I've invited Ahmed and Jorge on the repos and so they'll be able to transfer them whenever.

I can help, can you go to settings and in the danger zone tell me if you can transfer ownership to the org? I don't have repository permissions to allow me to move them via GitHub.

[theMimolet]

I can't transfer them either, I don't have any permissions in projectbluefin

[ahmedadan]

I can't transfer them either, I don't have any permissions in projectbluefin

You'll need to give me more broad repository access then? I don't see the danger zone at all.

[theMimolet]

I am probably missing something but I don't see how I could (?)
Otherwise I might need to transfer the repos to you first

[ahmedadan]

Can you try inviting me as an admin?

[ahmedadan]

I moved them both, thanks again for all the work here @theMimolet

[theMimolet]

Thanks a lot !
I observed there's no role management for personal repos, so this was the best solution