Skip to content

feat(core): [Logs and Metrics Enable Flags 9] Warn for legacy Logs configuration - #5950

Draft
adinauer wants to merge 2 commits into
feat/warn-legacy-logs-manifestfrom
feat/warn-legacy-logs-external
Draft

feat(core): [Logs and Metrics Enable Flags 9] Warn for legacy Logs configuration#5950
adinauer wants to merge 2 commits into
feat/warn-legacy-logs-manifestfrom
feat/warn-legacy-logs-external

Conversation

@adinauer

@adinauer adinauer commented Aug 13, 2026

Copy link
Copy Markdown
Member

PR Stack (Logs and Metrics Enable Flags)


📜 Description

Keeps parsing the nullable legacy logs.enabled external option and emits a tailored migration warning from SentryOptions.merge for explicit true and false values.

The legacy value no longer changes SDK behavior. Manual Sentry.logger() capture remains active for either value, while absent configuration emits no warning.

💡 Motivation and Context

The aggregate Logs enable flag was removed earlier in this stack. Existing sentry.properties, environment-variable, and system-property configurations need a clear migration diagnostic rather than being silently ignored.

💚 How did you test it?

  • ./gradlew :sentry:test
  • ./gradlew spotlessApply apiDump
  • Added external parsing tests for absent, true, and false values
  • Added merge tests for tailored warnings and unchanged manual Logs capture

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add the equivalent migration warning for legacy Spring Boot Logs configuration.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Keep parsing the nullable logs.enabled external option and emit tailored migration warnings for explicit true and false values without changing manual Logs capture.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8a414c2

@sentry

sentry Bot commented Aug 13, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.52.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 317.73 ms 376.65 ms 58.92 ms
Size 0 B 0 B 0 B

Previous results on branch: feat/warn-legacy-logs-external

Startup times

Revision Plain With Sentry Diff
623c4e5 312.67 ms 343.90 ms 31.23 ms

App size

Revision Plain With Sentry Diff
623c4e5 0 B 0 B 0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant