feat(spring): [Logs and Metrics Enable Flags 15] Warn for legacy Metrics property - #5956
Open
adinauer wants to merge 3 commits into
Open
feat(spring): [Logs and Metrics Enable Flags 15] Warn for legacy Metrics property#5956adinauer wants to merge 3 commits into
adinauer wants to merge 3 commits into
Conversation
Inspect the Spring Environment before SDK initialization and emit tailored migration warnings for explicit sentry.metrics.enabled values without binding or applying the obsolete property. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This was referenced Aug 13, 2026
📲 Install BuildsAndroid
|
This was referenced Aug 13, 2026
Contributor
Performance metrics 🚀
|
This was referenced Aug 13, 2026
This was referenced Aug 13, 2026
…y-metrics-spring # Conflicts: # sentry-spring-boot-4/src/main/java/io/sentry/spring/boot4/SentryAutoConfiguration.java # sentry-spring-boot-jakarta/src/main/java/io/sentry/spring/boot/jakarta/SentryAutoConfiguration.java # sentry-spring-boot/src/main/java/io/sentry/spring/boot/SentryAutoConfiguration.java
8 tasks
adinauer
marked this pull request as ready for review
August 13, 2026 13:41
adinauer
requested review from
markushi,
romtsn and
runningcode
as code owners
August 13, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Detects explicit
sentry.metrics.enabledconfiguration through Spring'sEnvironmentin all three Spring Boot variants. Migration warnings are emitted afterSentry.init, when the diagnostic logger has been initialized.Both
trueandfalsevalues emit tailored migration warnings. The obsolete property is not added back toSentryPropertiesand does not affect manual Metrics capture. Absent configuration emits no warning.💡 Motivation and Context
After removal of the aggregate Metrics option, Spring's relaxed binder ignores the old property. Inspecting the complete Spring
Environmentpreserves a useful migration diagnostic across property files, YAML, environment variables, command-line values, and other property sources.💚 How did you test it?
./gradlew :sentry-spring-boot:test :sentry-spring-boot-jakarta:test :sentry-spring-boot-4:test./gradlew spotlessApply apiDumptrue, and explicitfalsetests to all three Spring Boot variants📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Avoid starting the Metrics batch worker thread until the first accepted Metrics item.
#skip-changelog