feat(android): [Logs and Metrics Enable Flags 13] Warn for legacy Metrics metadata - #5954
Open
adinauer wants to merge 3 commits into
Open
feat(android): [Logs and Metrics Enable Flags 13] Warn for legacy Metrics metadata#5954adinauer wants to merge 3 commits into
adinauer wants to merge 3 commits into
Conversation
Detect explicit io.sentry.metrics.enabled manifest values and emit tailored migration warnings without applying the obsolete option. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This was referenced Aug 13, 2026
📲 Install BuildsAndroid
|
This was referenced Aug 13, 2026
This was referenced Aug 13, 2026
8 tasks
adinauer
marked this pull request as ready for review
August 13, 2026 13:41
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
August 13, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Detects explicit legacy
io.sentry.metrics.enabledAndroid manifest metadata and emits tailored migration warnings for bothtrueandfalsevalues.The obsolete metadata value is not applied. Manual
Sentry.metrics()capture remains active regardless of the configured value, and absent metadata emits no warning.💡 Motivation and Context
The aggregate Metrics enable option was removed in the previous PR. Existing Android applications may still configure its manifest key, so a focused warning helps users remove stale configuration without restoring the old behavior.
💚 How did you test it?
./gradlew :sentry-android-core:testReleaseUnitTest./gradlew spotlessApply apiDumptrue, and explicitfalsemetadata📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Add a migration warning for legacy external
metrics.enabledconfiguration.#skip-changelog