Skip to content

feat(android): [Logs and Metrics Enable Flags 8] Warn for legacy Logs metadata - #5949

Open
adinauer wants to merge 2 commits into
feat/remove-logs-enable-flagfrom
feat/warn-legacy-logs-manifest
Open

feat(android): [Logs and Metrics Enable Flags 8] Warn for legacy Logs metadata#5949
adinauer wants to merge 2 commits into
feat/remove-logs-enable-flagfrom
feat/warn-legacy-logs-manifest

Conversation

@adinauer

@adinauer adinauer commented Aug 13, 2026

Copy link
Copy Markdown
Member

PR Stack (Logs and Metrics Enable Flags)


📜 Description

Detects explicit io.sentry.logs.enabled Android manifest metadata and emits a tailored migration warning for both true and false values.

The legacy value is read only to select the warning. It does not change Timber or Logcat integration-local opt-ins, and absent metadata emits no warning.

💡 Motivation and Context

The aggregate Logs enable flag was removed in the previous PR. Android applications may still carry the old manifest key, so a targeted startup warning explains the new behavior and points users toward integration-local opt-ins without silently applying obsolete configuration.

💚 How did you test it?

  • ./gradlew :sentry-android-core:testReleaseUnitTest
  • ./gradlew spotlessApply apiDump
  • Added tests for absent, explicit true, and explicit false metadata
  • Verified legacy metadata does not mutate Timber or Logcat Logs options

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add equivalent migration warnings for legacy external and Spring Boot Logs configuration.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Detect explicit io.sentry.logs.enabled Android manifest metadata and emit tailored migration warnings without changing the integration-local Logs options.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4ed5fd2

@sentry

sentry Bot commented Aug 13, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.52.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 308.80 ms 350.24 ms 41.44 ms
Size 0 B 0 B 0 B

Baseline results on branch: feat/remove-logs-enable-flag

Startup times

Revision Plain With Sentry Diff
89eedb4 318.02 ms 383.41 ms 65.39 ms

App size

Revision Plain With Sentry Diff
89eedb4 0 B 0 B 0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant