feat(core): [Logs and Metrics Enable Flags 12] Remove Metrics enable flag - #5953
Open
adinauer wants to merge 3 commits into
Open
feat(core): [Logs and Metrics Enable Flags 12] Remove Metrics enable flag#5953adinauer wants to merge 3 commits into
adinauer wants to merge 3 commits into
Conversation
Contributor
|
📲 Install BuildsAndroid
|
Capture manual Metrics without an aggregate option and always create the configured batch processor. Keep legacy external and Android keys only for subsequent migration warnings. Co-Authored-By: Claude <noreply@anthropic.com>
adinauer
force-pushed
the
feat/remove-metrics-enable-flag
branch
from
August 13, 2026 04:02
d1c27d7 to
0a41b97
Compare
This was referenced Aug 13, 2026
Contributor
Performance metrics 🚀
|
This was referenced Aug 13, 2026
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Removes the aggregate Metrics enable option from
SentryOptions.Metrics. ManualSentry.metrics()calls now capture without an enable flag, andSentryClientalways creates the configured Metrics batch processor.Legacy
metrics.enabledexternal configuration andio.sentry.metrics.enabledAndroid metadata remain detectable for follow-up migration warnings, but their values are no longer applied.NoOpMetricsBatchProcessorremains available as a separate public API.💡 Motivation and Context
Metrics are a manual namespaced API and no production integration currently generates them automatically. Requiring an aggregate enable option adds configuration without protecting users from automatic instrumentation.
💚 How did you test it?
./gradlew :sentry:test :sentry-android-core:testReleaseUnitTest./gradlew spotlessApply apiDumpfalsevalues do not disable capture📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Add an Android migration warning for explicit legacy
io.sentry.metrics.enabledmetadata.