fix(core): [Logs and Metrics Enable Flags 20] Make migration warnings visible - #5966
Open
adinauer wants to merge 1 commit into
Open
fix(core): [Logs and Metrics Enable Flags 20] Make migration warnings visible#5966adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Initialize the fatal logger before external configuration is merged and route legacy Logs and Metrics migration warnings through the always-visible startup logger across core, Android, and Spring Boot. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 13, 2026
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
adinauer
marked this pull request as ready for review
August 13, 2026 13:41
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
August 13, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Routes obsolete Logs and Metrics enable-flag migration warnings through the always-visible fatal logger across core external configuration, Android manifest metadata, and all three Spring Boot variants.
Core now initializes its fatal logger before external configuration is merged. Android continues using
AndroidFatalLogger, whose output is emitted atLog.ASSERT. Spring emits its warnings afterSentry.init, when the fatal logger is initialized.💡 Motivation and Context
The migration warnings previously used the diagnostic logger. During external configuration merge that logger was still a no-op, and in Android or Spring normal startup it remained hidden unless SDK debug logging or a custom diagnostic logger was enabled.
These warnings are the migration path for removed aggregate options, so explicit obsolete configuration should be visible without asking users to enable debug logging.
💚 How did you test it?
./gradlew :sentry:test :sentry-android-core:testReleaseUnitTest :sentry-spring-boot:test :sentry-spring-boot-jakarta:test :sentry-spring-boot-4:test./gradlew spotlessApply apiDumpSystemOutLoggerwith debug disabledLog.ASSERTwith debug disabled📝 Checklist
sendDefaultPIIis enabled.#skip-changelog