Skip to content

fix(core): [Logs and Metrics Enable Flags 20] Make migration warnings visible - #5966

Open
adinauer wants to merge 1 commit into
fix/timber-lazy-logs-optionfrom
fix/visible-enable-flag-warnings
Open

fix(core): [Logs and Metrics Enable Flags 20] Make migration warnings visible#5966
adinauer wants to merge 1 commit into
fix/timber-lazy-logs-optionfrom
fix/visible-enable-flag-warnings

Conversation

@adinauer

@adinauer adinauer commented Aug 13, 2026

Copy link
Copy Markdown
Member

PR Stack (Logs and Metrics Enable Flags)


📜 Description

Routes obsolete Logs and Metrics enable-flag migration warnings through the always-visible fatal logger across core external configuration, Android manifest metadata, and all three Spring Boot variants.

Core now initializes its fatal logger before external configuration is merged. Android continues using AndroidFatalLogger, whose output is emitted at Log.ASSERT. Spring emits its warnings after Sentry.init, when the fatal logger is initialized.

💡 Motivation and Context

The migration warnings previously used the diagnostic logger. During external configuration merge that logger was still a no-op, and in Android or Spring normal startup it remained hidden unless SDK debug logging or a custom diagnostic logger was enabled.

These warnings are the migration path for removed aggregate options, so explicit obsolete configuration should be visible without asking users to enable debug logging.

💚 How did you test it?

  • ./gradlew :sentry:test :sentry-android-core:testReleaseUnitTest :sentry-spring-boot:test :sentry-spring-boot-jakarta:test :sentry-spring-boot-4:test
  • ./gradlew spotlessApply apiDump
  • Verified JVM external configuration writes through SystemOutLogger with debug disabled
  • Verified Android manifest warnings appear at Log.ASSERT with debug disabled
  • Verified Spring warnings use a configured fatal logger without enabling debug logging

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Initialize the fatal logger before external configuration is merged and route legacy Logs and Metrics migration warnings through the always-visible startup logger across core, Android, and Spring Boot.

Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 13, 2026
@sentry

sentry Bot commented Aug 13, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.52.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.18 ms 477.06 ms 83.88 ms
Size 0 B 0 B 0 B

@adinauer
adinauer marked this pull request as ready for review August 13, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant